Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46173: Allow negative values for ra and dec #1072

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Sep 6, 2024

Fix an issue where ra and dec values in POINT() query expressions could not be negative.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@dhirving dhirving force-pushed the tickets/DM-46173 branch 2 times, most recently from 7d0e1ca to ed78873 Compare September 6, 2024 22:13
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (5c4a71f) to head (d33ed6f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         359      359           
  Lines       46925    46935   +10     
  Branches     9650     9652    +2     
=======================================
+ Hits        42073    42086   +13     
+ Misses       3485     3481    -4     
- Partials     1367     1368    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving marked this pull request as ready for review September 6, 2024 22:31
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Should we add a small test to tests/test_exprParserYacc.py?

@dhirving
Copy link
Contributor Author

dhirving commented Sep 6, 2024

Should we add a small test to tests/test_exprParserYacc.py?

There's already coverage for this syntax in there: https://github.com/lsst/daf_butler/blob/tickets/DM-45933/tests/test_exprParserYacc.py#L165

@timj
Copy link
Member

timj commented Sep 6, 2024

Ok. I wasn't sure if that part of the code testing for POINT syntax was also responsible for checking for the negative value.

@dhirving
Copy link
Contributor Author

dhirving commented Sep 6, 2024

Ok. I wasn't sure if that part of the code testing for POINT syntax was also responsible for checking for the negative value.

As far as the grammar is concerned, POINT() is an arbitrary function and its parameters can be any expressions.

Fix an issue where ra and dec values in POINT() query expressions could not be negative.
@dhirving dhirving merged commit 5a6ff82 into main Sep 10, 2024
17 checks passed
@dhirving dhirving deleted the tickets/DM-46173 branch September 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants